This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: breakpoint.c patch (prelude to pending breakpoint support)


On Thu, Dec 11, 2003 at 02:33:41PM -0500, J. Johnston wrote:
> Eli Zaretskii wrote:
> >>Date: Thu, 11 Dec 2003 11:32:46 -0500
> >>From: "J. Johnston" <jjohnstn@redhat.com>
> >>
> >>>Is this line really that long, or did your mailer mess it up?  If the
> >>>former, it needs to be reformatted.
> >>
> >>Eli, I realize you are just making a minor comment, but can I ask that 
> >>gdb maintainers please start trusting me on this.
> >
> >
> >Sorry, I didn't in any way mean to say that I didn't trust you.  I
> >couldn't possibly know whether what I saw was a real mistake on your
> >part or not, and I think it isn't reasonable to request me to check
> >your previous ChangeLog entries in order to decide one way or the
> >other.  One popular reason for messed-up formatting is your mailer,
> >so I took care to inquire about that before assuming that what I see
> >is what you meant.
> >
> >Could we please assume that the comments you get are meant to make
> >sure the code is up to the standards, not to diminish your abilities
> >or show signs of mistrust?
> >
> >
> 
> No need to apologize.  I wasn't trying to imply that you didn't trust me 
> nor was I offended in any way.  The request was to all gdb global 
> maintainers out there. The comment about the line length for my ChangeLog 
>  entries comes up continously and I thought it was time I just pointed out 
> that I am on the same page as everyone else with regards to this.

We can't stop complaining about misformated entries for everybody,
since a lot of people get them wrong - I do this routinely myself. 
It's a common problem.

I think that the same rules for posting patches should apply to posting
changelog entries - it's not acceptable to post a different patch than
you'll check in, after all.

Just my two cents.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]