This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: breakpoint.c patch (prelude to pending breakpoint support)
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Jeff Johnston <jjohnstn at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 10 Dec 2003 23:09:22 -0500
- Subject: Re: [RFA]: breakpoint.c patch (prelude to pending breakpoint support)
- References: <3FD7C458.2080404@redhat.com>
On Wed, Dec 10, 2003 at 08:11:52PM -0500, Jeff Johnston wrote:
> The following is a patch to centralize the test for an active-enabled
> breakpoint. This patch is in response to Daniel J's comments to split
> up the pending-breakpoint support patch. With pending breakpoint
> support, the test will be modified to include a check for a pending
> breakpoint. This will simplify reviewing the last of the patches
> required for pending-breakpoint support.
>
> Ok to commit?
>
> -- Jeff J.
>
> 2003-12-10 Jeff Johnston <jjohnstn@redhat.com>
>
> * breakpoint.c (breakpoint_enabled): New function to test whether
> breakpoint is
> active and enabled.
> ( insert_bp_location, insert_breakpoints): Call new function to test
> for enabled breakpoint.
> (remove_breakpoint, breakpoint_here_p): Ditto.
> (breakpoint_thread_match): Ditto.
> (bpstat_should_step, bpstat_have_active_hw_watchpoints): Ditto.
> (disable_breakpoints_in_shlibs): Ditto.
> (hw_watchpoint_used_count): Ditto.
> (disable_watchpoints_before_interactive_call_start): Ditto.
> (breakpoint_re_set_one): Ditto.
> (bpstat_stop_status): Use new function and simplify test.
This is fine! Thanks for splitting it up.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer