This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/dwarf] Kill some more unnecessary global variables
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Tue, 2 Dec 2003 11:41:46 -0500
- Subject: Re: [rfa/dwarf] Kill some more unnecessary global variables
- References: <20031123225631.GA26113@nevyn.them.org> <vt21xrxabys.fsf@zenia.home>
On Mon, Nov 24, 2003 at 12:54:51PM -0500, Jim Blandy wrote:
> Daniel Jacobowitz <drow@mvista.com> writes:
>
> > Now that we pass the section to dwarf2_read_section, we don't need to
> > pass the offset and size parameters also. After removing them, it turns out
> > that the global offset variables are only:
> > - passed to dwarf2_read_section
> > - tested for non-zero-ness to indicate presence of the section
> > And testing the section pointer works just as well, so we can remove the
> > offsets.
> >
> > This is part of the global state in dwarf2read crusade. The remaining
> > section info is probably going to move into the objfile as per-objfile data,
> > but I wanted to prune the deadwood first.
> >
> > OK?
>
> Yes! Please commit.
Thanks, checked in now.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer