This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa:symtab] deprecate inside_entry_func


On Nov 21,  4:54pm, Daniel Jacobowitz wrote:

> On Fri, Nov 21, 2003 at 02:24:16PM -0700, Kevin Buettner wrote:
> > On Nov 21,  4:04pm, Daniel Jacobowitz wrote:
> > 
> > > I imagine the third caller, in frv-tdep.c, is bogus
> > > and could be removed somehow.  But if it's going to be left there then
> > > it seems reasonable to update it also.
> > 
> > I had thought that get_prev_frame's call to inside_entry_func() had
> > been disabled pending a demonstration that it's needed.  Hmm...  I see
> > I was getting this confused with the code corresponding to
> > inside_entry_file().
> > 
> > Okay, that means that frv-tdep.c's use of inside_entry_func() can go
> > away.  I'll get rid of it.
> 
> Are you sure?
> 
>   /* NOTE: cagney/2003-07-15: Need to add a "set backtrace
>      beyond-entry-func" command so that this can be selectively
>      disabled.  */
>   if (0
> #if 0
>       && backtrace_beyond_entry_func
> #endif
>       && this_frame->type != DUMMY_FRAME && this_frame->level >= 0
>       && inside_entry_func (get_frame_pc (this_frame)))

Oops.  You're right.

(My attention was so focused on the limited scope of the ``#if 0'' that
I failed to notice the 0 in the ``if'' conditional.)

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]