This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] Fix two xfer partial bugs; Was; RFA: ia64 portion oflibunwind patch
- From: "J. Johnston" <jjohnstn at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: Daniel Jacobowitz <drow at mvista dot com>,Kevin Buettner <kevinb at redhat dot com>,Marcel Moolenaar <marcel at xcllnt dot net>, gdb-patches at sources dot redhat dot com
- Date: Thu, 06 Nov 2003 15:12:14 -0500
- Subject: Re: [commit] Fix two xfer partial bugs; Was; RFA: ia64 portion oflibunwind patch
- Organization: Red Hat Inc.
- References: <3F986E31.8050201@redhat.com> <1031024175718.ZM3475@localhost.localdomain> <3F996D88.9060505@redhat.com> <1031024185625.ZM9827@localhost.localdomain> <3F9F0180.2010702@redhat.com> <20031029012833.GA11070@nevyn.them.org> <3FA043B2.6090401@redhat.com> <3FA7F97B.4090909@redhat.com> <3FAAA90D.3040104@redhat.com>
Andrew Cagney wrote:
Jeff,
I've just committed the attached. It fixes two bugs when using xfer
partial in an existing target.
- the "add_target" method was always overriding the child's
to_xfer_partial method. The consequence is that the code your patch
adds is never called!
- the code would all off the end of a stack which this part of the
change fixed: * target.c (init_dummy_target): Initialize to_xfer_partial
to default.
I've one more tweak to the target code. Once thats in can you please
confirm that this new child method is called and is needed - seems
things work without it?
Yes. It is only called if the find_pc_in_section() call fails which it doesn't
for the gdb testsuite.
I can try hardwiring a failure to verify that code works once you have your
changes in.
-- Jeff J.