This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[patch/rfc] OSABI cleanups
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 24 Oct 2003 14:39:55 -0400
- Subject: [patch/rfc] OSABI cleanups
Mostly FYI,
In preparing that wildcard OSABI patch, I tripped over the following:
- info already contains bfd arch info
(if it doesn't, we're stuffed :-)
- use warning() and not fprintf_filtered() for the message
I'll commit in a day or so,
Andrew
2003-10-24 Andrew Cagney <cagney@redhat.com>
* osabi.c (gdbarch_init_osabi): Use info.bfd_arch_info instead of
arch_info. Use warning instead of fprintf_filtered. Do not use
deprecated bfd_printable_arch_mach.
Index: osabi.c
===================================================================
RCS file: /cvs/src/src/gdb/osabi.c,v
retrieving revision 1.20
diff -u -r1.20 osabi.c
--- osabi.c 24 Oct 2003 17:37:03 -0000 1.20
+++ osabi.c 24 Oct 2003 18:16:57 -0000
@@ -305,7 +305,6 @@
void
gdbarch_init_osabi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
- const struct bfd_arch_info *arch_info = gdbarch_bfd_arch_info (gdbarch);
struct gdb_osabi_handler *handler;
if (info.osabi == GDB_OSABI_UNKNOWN)
@@ -341,20 +340,18 @@
(or more generally "64-bit ISA can run code for the 32-bit
ISA"). BFD doesn't normally consider 32-bit and 64-bit
"compatible" so it doesn't succeed. */
- if (can_run_code_for (arch_info, handler->arch_info))
+ if (can_run_code_for (info.bfd_arch_info, handler->arch_info))
{
(*handler->init_osabi) (info, gdbarch);
return;
}
}
- fprintf_filtered
- (gdb_stderr,
- "A handler for the OS ABI \"%s\" is not built into this "
- "configuration of GDB. "
- "Attempting to continue with the default %s settings",
- gdbarch_osabi_name (info.osabi),
- bfd_printable_arch_mach (arch_info->arch, arch_info->mach));
+ warning ("A handler for the OS ABI \"%s\" is not built into this "
+ "configuration of GDB. "
+ "Attempting to continue with the default %s settings",
+ gdbarch_osabi_name (info.osabi),
+ info.bfd_arch_info->printable_name);
}