Re: [RFA] New threads test

[Michael Snyder <msnyder at redhat dot com>]

Daniel Jacobowitz wrote:
> On Wed, Oct 01, 2003 at 02:52:30PM -0400, Daniel Jacobowitz wrote:
>
> > On Wed, Oct 01, 2003 at 11:37:11AM -0700, Michael Snyder wrote:
> >
> > > Daniel Jacobowitz wrote:
> > >
> > > > This is a test for the remote protocol issue I'm solving with vCont.  It
> > > > also shows up in schedlock, but the simpler test makes it much clearer
> > > > what's going wrong.  OK?
> > >
> > > Umm... what is going wrong?  What are you testing for here?
> >
> > +# It tests that the correct thread is single-stepped.
> >
> > More intelligibly: when gdbserver is told to single-step one thread
> > (without holding all others schedlocked), it assumes we mean the first
> > thread.  Which might not be the _right_ thread.

Hmmm... it should assume we mean the _current_ thread
(ie. the one that had a stop event).  The remote protocol
should cover this (and did, last I checked).

> Hi Michael,
>
> Is this test OK (with a better comment and the copyright notice that
> Michael C suggested)?

OK, with emphasis on "more comments".