This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: correctly place new inclusions in includer's list


On 22 Sep 2003 14:39:08 -0500, Jim Blandy <jimb@redhat.com> said:
> David Carlton <carlton@kealia.com> writes:

>> I've seen macrotab seg faults intermittently over the last few
>> months; I've been too lazy to track them down (they're hard to
>> reproduce, and I didn't know if it was something weird about my
>> branch or a bug in mainline), but if this patch might fix them, and
>> if it's as trivial as it seems, then putting it in 6.0 makes sense
>> to me.

> It's hard to see how this would fix any seg faults.  It just fixes
> where in the list the traversal stops; but no matter where it stops,
> the other loop conditions ensure that it stops in a structurally
> valid state.

> So I'd say the segfaults you've seen don't weigh for or against.

Oh well.  I'll keep my eye out for them (I haven't seen one in a
little while) and see if I can find a way to reproduce them regularly
(or fix them?), then.

David Carlton
carlton@kealia.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]