This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] IBM6000_TARGET is wrong for NetBSD/powerpc


Hi Jason,

Did you see this patch?  It looks right to me, but you're the NetBSD
maintainer :)

Unfortuatly not from a multi-arch point of view :-( The number of #defines and #undefines should be overall decreasing. Here, it would be better to either:

- re-arange tm-rs6000.h so that the define wasn't needed
- move the define to nm-rs6000.h (sick but effective :-)

Andrew


Index: tm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/tm-nbsd.h,v
retrieving revision 1.2
diff -u -r1.2 tm-nbsd.h
--- tm-nbsd.h 22 May 2002 03:59:55 -0000 1.2
+++ tm-nbsd.h 14 Aug 2003 22:09:26 -0000
@@ -23,4 +23,8 @@
#include "powerpc/tm-ppc-eabi.h"
+/* We _want_ the SVR4 section offset calculations (see syms_from_objfile()
+ in symfile.c) */
+#undef IBM6000_TARGET
+
#endif /* TM_NBSD_H */




-- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]