This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] missing case in epilogue stub detection
On Tue, Aug 26, 2003 at 03:36:59PM -0700, Jafa wrote:
> The following patch fixes a bug where an epilogue stub isn't detected and is
> erroneously treated as a subroutine.
>
> Fixes step and next errors when at the end of a function for the ip2k. Mips
> may have suffered from the same problem but the occurrence of the code would
> have been rare.
>
> 2003-08-26 Nick Kelsey <nickk@ubicom.com>
>
> * infrun.c (handle_inferior_event): Bug fix in subroutine detection
> code regarding dealing with an epilogue stub. The previous code correctly
> detected the stub in all cases except where the pc is equal to the stub
> entry point.
First of all, please use context or (my preference) unified diff.
Second of all, please obey the coding standards; you removed a comment
and made a line too long.
And the actual problem, please explain what the bug is and why this
change is correct. From the patch I'll make a wild guess: stop_pc ==
ecs->stop_func_start but in_prologue returns false. That looks like a
bug in your target's prologue code.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer