This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commit] Don't try to build monitor.c with -Werror
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sun, 10 Aug 2003 15:55:26 -0400
- Subject: [commit] Don't try to build monitor.c with -Werror
See my post to gdb@, turns out the code is bad broken.
committed,
Andrew
2003-08-10 Andrew Cagney <cagney@redhat.com>
* Makefile.in (monitor.o): Do not build monitor.c with -Werror.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.424
diff -u -r1.424 Makefile.in
--- Makefile.in 8 Aug 2003 17:30:35 -0000 1.424
+++ Makefile.in 10 Aug 2003 19:50:15 -0000
@@ -1321,6 +1321,15 @@
$(CC) -c $(INTERNAL_CFLAGS) $(TARGET_SYSTEM_ROOT_DEFINE) \
-DBINDIR=\"$(bindir)\" $(srcdir)/main.c
+# FIXME: cagney/2003-08-10: "monitor.c" gets -Wformat-nonliteral
+# errors. It turns out that that is the least of monitor.c's
+# problems. The function print_vsprintf appears to be using
+# va_arg(long) to extract CORE_ADDR parameters - something that
+# definitly will not work. "monitor.c" needs to be rewritten so that
+# it doesn't use format strings and instead uses callbacks.
+monitor.o: $(srcdir)/monitor.c
+ $(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) $(srcdir)/monitor.c
+
# FIXME: Procfs.o gets -Wformat errors because things like pid_t don't
# match output format strings.
procfs.o: $(srcdir)/procfs.c