This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error


On Mon, Aug 04, 2003 at 03:26:03PM +0900, Kei Sakamoto wrote:
> Thank you, everyone. Now m32r is back! :-)
> 
> The attached fixes compile errors of asm-source.exp for m32r-elf.
> There are several missing symbols.
> 
> It also replaces ld24 instruction with seth/add3 instruction.
> ld24 can handle only 24bit address, so ld24 fails to set sp when
> _stack is located at a large address.
> 
> Kei Sakamoto
> 
> ===
> 
> 2003-08-04    Kei Sakamoto  <sakamoto.kei@renesas.com>
> 
> * gdb.asm/m32r.inc : Add several missing symbols. Replace ld24
>                      with seth/add3.

Two minor things:
  - You accidentally sent a reversed diff.
  - ChangeLog formatting.  It should be:

2003-08-04  Kei Sakamoto  <sakamoto.kei@renesas.com>

	* gdb.asm/m32r.inc: Add several missing symbols. Replace ld24
	with seth/add3.

One less minor thing: no other port needs to declare symbols.  It looks
like part of libc is being dragged in somehow on m32r; could you
explain why the symbols are necessary?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]