This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch,6.0,rfc,rfa:doco] Finish "mi2"/"mi3" rollover


Hello,

This finishes the mi1/mi2/mi3 rollover. It also fixes a bug. The previous changes forgot to register "mi2", and set "mi" to "mi3". Anyway it:

- adds "mi2" and "mi3"
- makes "mi" select "mi2" the last released "mi" version.
- updates the doco to mention that "mi2" was released in GDB 6.0
- rolls the testsuite so that there is a frozen mi2-*.exp

Note that "mi" is selecting "mi2" the last released version, and not the next version. This gives better consistency between the last branch and the current release - "mi" should select the same thing - and that might encourage people to pick up current snaps.

I expect adding this to 6.0 and mainline in a few days.

I should note that I'm not sure how consistent my rollover process is - I suspect last time "mi" ended up selecting the mainline, instead of the previous released version. I guess, given miN as the default, the process is:

Freeze an MI version (on the branch):
- delete mi{N-1}
- make "mi" select mi{N+1}
- copy mi{N+1}-*.exp to mi-*.exp, s/-i=mi{N+1}/-i=mi/

Start a new MI version (on the mainline):
- add mi{N+2}
- copy mi{N+1)-*.exp to mi{N+2}-*.exp, s/-i=mi{N+1}/-i=mi{N+2}/

thoughts?
Andrew
Index: doc/ChangeLog
2003-08-04  Andrew Cagney  <cagney@redhat.com>

	* gdb.texinfo (Mode Options): Mention that "mi2" was included in
	GDB 6.0.

Index: mi/ChangeLog
2003-08-04  Andrew Cagney  <cagney@redhat.com>

	* mi-interp.c (_initialize_mi_interp): Register "mi2" and "mi3".
	Make "mi" select "mi2".

Index: ChangeLog
2003-08-04  Andrew Cagney  <cagney@redhat.com>

	* interps.h (INTERP_MI2, INTERP_MI3): Define.

Index: testsuite/gdb.mi/ChangeLog
2003-08-04  Andrew Cagney  <cagney@redhat.com>

	* mi2-basics.exp: Copy base MI .exp file, set MIFLAGS to -i=mi2.
	* mi2-break.exp, mi2-cli.exp, mi2-console.exp: Ditto.
	* mi2-disassemble.exp, mi2-eval.exp, mi2-file.exp: Ditto.
	* mi2-hack-cli.exp, mi2-pthreads.exp, mi2-read-memory.exp: Ditto.
	* mi2-regs.exp, mi2-return.exp, mi2-simplerun.exp: Ditto.
	* mi2-stack.exp, mi2-stepi.exp, mi2-syn-frame.exp: Ditto.
	* mi2-until.exp, mi2-var-block.exp, mi2-var-child.exp: Ditto.
	* mi2-var-cmd.exp, mi2-var-display.exp, mi2-watch.exp: Ditto.

Index: interps.h
===================================================================
RCS file: /cvs/src/src/gdb/interps.h,v
retrieving revision 1.4
diff -u -r1.4 interps.h
--- interps.h	8 Jun 2003 18:27:13 -0000	1.4
+++ interps.h	4 Aug 2003 19:14:19 -0000
@@ -68,6 +68,8 @@
 /* well-known interpreters */
 #define INTERP_CONSOLE		"console"
 #define INTERP_MI1             "mi1"
+#define INTERP_MI2             "mi2"
+#define INTERP_MI3             "mi3"
 #define INTERP_MI		"mi"
 
 #endif
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.171
diff -u -r1.171 gdb.texinfo
--- doc/gdb.texinfo	26 Jul 2003 07:38:54 -0000	1.171
+++ doc/gdb.texinfo	4 Aug 2003 19:17:06 -0000
@@ -1130,11 +1130,11 @@
 @xref{Interpreters, , Command Interpreters}.
 
 @samp{--interpreter=mi} (or @samp{--interpreter=mi2}) causes
-@value{GDBN} to use the current @dfn{@sc{gdb/mi} interface}
-(@pxref{GDB/MI, , The @sc{gdb/mi} Interface}).  The previous @sc{gdb/mi}
-interface, included in @value{GDBN} version 5.3, can be selected with
-@samp{--interpreter=mi1}.  Earlier @sc{gdb/mi} interfaces
-are not supported.
+@value{GDBN} to use the @dfn{@sc{gdb/mi} interface} (@pxref{GDB/MI, ,
+The @sc{gdb/mi} Interface}) included in @var{GDBN} version 6.0.  The
+previous @sc{gdb/mi} interface, included in @value{GDBN} version 5.3,
+can be selected with @samp{--interpreter=mi1}.  Earlier @sc{gdb/mi}
+interfaces are not supported.
 
 @item -write
 @cindex @code{--write}
Index: mi/mi-interp.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-interp.c,v
retrieving revision 1.4
diff -u -r1.4 mi-interp.c
--- mi/mi-interp.c	8 Jun 2003 18:27:14 -0000	1.4
+++ mi/mi-interp.c	4 Aug 2003 19:17:23 -0000
@@ -407,8 +407,12 @@
     mi_interpreter_prompt_p	/* prompt_proc_p */
   };
 
-  /* Create MI1 interpreter */
+  /* The various interpreter levels.  */
   interp_add (interp_new (INTERP_MI1, NULL, mi_out_new (1), &procs));
+  interp_add (interp_new (INTERP_MI2, NULL, mi_out_new (2), &procs));
+  interp_add (interp_new (INTERP_MI3, NULL, mi_out_new (3), &procs));
 
-  interp_add (interp_new (INTERP_MI, NULL, mi_out_new (3), &procs));
+  /* "mi" selects the most recent released version.  "mi2" was
+     released as part of GDB 6.0.  */
+  interp_add (interp_new (INTERP_MI, NULL, mi_out_new (2), &procs));
 }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]