This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH: Fix DW_OP_deref for DW_TAG_formal_parameter
- From: "H. J. Lu" <hjl at lucon dot org>
- To: GDB <gdb-patches at sources dot redhat dot com>
- Date: Thu, 31 Jul 2003 09:39:50 -0700
- Subject: Re: PATCH: Fix DW_OP_deref for DW_TAG_formal_parameter
- References: <20030730215421.GA26408@lucon.org> <20030730215612.GB15640@nevyn.them.org> <20030731002306.GA28960@lucon.org> <20030731002753.GA18866@nevyn.them.org> <20030731154405.GA11592@lucon.org> <20030731154821.GA10106@nevyn.them.org> <20030731161259.GA11965@lucon.org> <20030731162207.GA24040@nevyn.them.org>
On Thu, Jul 31, 2003 at 12:22:07PM -0400, Daniel Jacobowitz wrote:
> On Thu, Jul 31, 2003 at 09:12:59AM -0700, H. J. Lu wrote:
> > On Thu, Jul 31, 2003 at 11:48:21AM -0400, Daniel Jacobowitz wrote:
> > > On Thu, Jul 31, 2003 at 08:44:05AM -0700, H. J. Lu wrote:
> > > > On Wed, Jul 30, 2003 at 08:27:53PM -0400, Daniel Jacobowitz wrote:
> > > > > On Wed, Jul 30, 2003 at 05:23:06PM -0700, H. J. Lu wrote:
> > > > > > On Wed, Jul 30, 2003 at 05:56:12PM -0400, Daniel Jacobowitz wrote:
> > > > > > > On Wed, Jul 30, 2003 at 02:54:21PM -0700, H. J. Lu wrote:
> > > > > > > > Does DW_OP_deref work correctly with gdb?
> > > > > > >
> > > > > > > That depends on the context. Things that use decode_locdesc, probably
> > > > > > > not. As we find time, things are being converted to the full
> > > > > > > expression evaluator. Location descriptions and frame bases should
> > > > > > > work.
> > > > > >
> > > > > > I don't think it does. Intel Fortran compiler generartes DW_OP_deref.
> > > > > > I got
> > > > >
> > > > > Location descriptions for parameters may not work fully. Feel free to
> > > > > fix it, or to investigate the reasons why more thoroughly - search for
> > > > > LOC_COMPUTED_ARG, but I don't even think we generate those yet.
> > > > >
> > > >
> >
> > > Please look more closely at what I suggested, and at how DW_OP_deref
> > > works for DW_TAG_variable (as opposed to DW_TAG_formal_parameter). All
> > > of the above should be turned into LOC_COMPUTED_ARG.
> > >
> >
> > Thanks. This patch works for me.
>
> Could you test this alternative? The goal is to eliminate calls to
> decode_locdesc.
>
Yes, it works.
Thanks.
H.J.