Re: [RFA] Re: Analyzing AMD64 corefiles on i386

[Mark Kettenis <kettenis at chello dot nl>]

   Date: Wed, 09 Jul 2003 13:03:06 +0200
   From: Michal Ludvig <mludvig@suse.cz>

   This is a multi-part message in MIME format.
   --------------050406070409000508090803
   Content-Type: text/plain; charset=us-ascii; format=flowed
   Content-Transfer-Encoding: 7bit

   Mark Kettenis told me that:
   >    Date: Tue, 08 Jul 2003 14:43:49 +0200
   >    From: Michal Ludvig <mludvig@suse.cz>
   > 
   >    Hi,
   >    what must be done to enable reading of AMD64 corefiles in a gdb running 
   >    on i386 with --target=amd64?
   > 
   > The necessary support for corefiles needs to be added to
   > x86-64-linux-tdep.c.  Take a look at i386nbsd-tdep.c for an example.
   > You'll need to create a `struct core_fns' together with the necessary
   > support functions, and register it with add_core_fns.  Note that for
   > the support functions you can't rely on definitions in header files
   > and such since this is target code.  You'll also need to drop
   > core-regset.o from NATDEPFILES in x86-64-linux.mh.

   How about the attached one? Works for me on cross-gdb i386->amd64 as 
   well as in native amd64 gdb. Can I apply it?

Not as such.  We can't allow public functions with the names
supply_gregset and fill_gregset in *-tdep.c files.  Therefore these
functions should be renamed, and supply_gregset and fill_gregset
should be kept in your *-nat.c file.  You'll probably want to rewrite
those functions such that they call the new functions in *-tdep.c.

Personally I wouldn't define all those constants if the only place
where they'll be used is the regmap array, but that's a matter of
taste.

Mark