This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/ARM] Framificate the ARM port [3/3]
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, rearnsha at arm dot com
- Date: Tue, 1 Jul 2003 18:26:15 -0400
- Subject: Re: [RFA/ARM] Framificate the ARM port [3/3]
- References: <20030630225509.GA30844@nevyn.them.org> <3F01D27B.8070603@redhat.com>
On Tue, Jul 01, 2003 at 02:27:07PM -0400, Andrew Cagney wrote:
> >Index: gdb/varobj.c
> >===================================================================
> >--- gdb.orig/varobj.c 2003-06-30 18:28:07.000000000 -0400
> >+++ gdb/varobj.c 2003-06-30 18:28:57.000000000 -0400
> >@@ -412,7 +412,7 @@ find_frame_addr_in_frame_chain (CORE_ADD
> > frame = get_prev_frame (frame);
> > if (frame == NULL)
> > return NULL;
> >- if (get_frame_base (frame) == frame_addr)
> >+ if (get_frame_base_address (frame) == frame_addr)
> > return frame;
> > }
>
> Just in case you're wondering.
>
> This would break any architecture that didn't have an FP called "fp".
> This is because, "$fp" defaults to get_frame_base() ... :-(
Argh!
get_frame_base_address defaults to get_frame_base; I could update
value_of_builtin_frame_fp_reg safely, I think. But I have no idea
where that would end up, so I'm going to defer to your judgement on
this if you've got a preference...
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer