This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] [avr] remove avr_push_dummy_code method.



On Thu, 19 Jun 2003, Andrew Cagney wrote:

> > Hi,
> >
> > Committed the attached.
> >
> > This removes the avr_push_dummy_code function. It doesn't seem to be
> > needed and what I committed last night didn't return anything which
> > broke the -Werror build. :-(
>
> Push dummy code only gets called when CALL_DUMMY_LOCATION == ON_STACK,
> and even then, the default (just write a breakpoint onto the stack)
> should be sufficient.
>
> Unless AVR has something approaching the SPARC ABI that is....  (See the
> quote from Peter Schauer in sparc-tdep.c).

Thanks. That gives me more confidence that I really don't need that
funciton. I had looked at the code where CALL_DUMMY_LOCATION ==
ON_STACK and it looked like generic_push_dummy_code() was sufficient.

Ted Roth


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]