This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: always_use_struct_convention
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 13 Jun 2003 00:17:48 -0400
- Subject: Re: RFA: always_use_struct_convention
- References: <vt2znkpt90b.fsf@zenia.home> <3EE72AD9.4090609@redhat.com>
This is almost obvious...
2003-06-11 Jim Blandy <jimb@redhat.com>
* arch-utils.c (always_use_struct_convention): New function.
* arch-utils.h (always_use_struct_convention): New prototype.
* alpha-tdep.c (alpha_use_struct_convention): Delete.
(alpha_gdbarch_init): Register always_use_struct_convention,
instead of alpha_use_struct_convention.
* cris-tdep.c (cris_use_struct_convention): Delete.
(cris_gdbarch_init): Register always_use_struct_convention,
instead of cris_use_struct_convention.
* frv-tdep.c (frv_use_struct_convention): Delete.
(frv_gdbarch_init): Register always_use_struct_convention,
instead of frv_use_struct_convention.
* h8300-tdep.c (h8300_use_struct_convention): Delete.
(h8300_gdbarch_init): Register always_use_struct_convention,
instead of h8300_use_struct_convention.
* mips_o32-tdep.c (mips_o32_use_struct_convention): Delete.
(mips_o32_gdbarch_init): Register always_use_struct_convention,
instead of mips_o32_use_struct_convention.
No, it is obvious :-) Nice catch.
Well, almost. The patch broke mips-elf :-(
/home/cagney/PENDING/2003-06-12-deprecate-register/src/gdb/mips-tdep.c:
In function `mips_gdbarch_init':
/home/cagney/PENDING/2003-06-12-deprecate-register/src/gdb/mips-tdep.c:5794:
`mips_o32_use_struct_convention' undeclared (first use in this function)
Please be sure to check that the change doesn' break the cross target
builds. The script gdb/gdb_mbuild.sh helps.
I checked in the attached.
Andrew
2003-06-13 Andrew Cagney <cagney@redhat.com>
* mips-tdep.c (mips_gdbarch_init): Replace remaining instances of
mips_o32_use_struct_convention with always_use_struct_convention.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.212
diff -u -r1.212 mips-tdep.c
--- mips-tdep.c 12 Jun 2003 23:25:37 -0000 1.212
+++ mips-tdep.c 13 Jun 2003 04:16:14 -0000
@@ -5790,8 +5790,7 @@
set_gdbarch_long_long_bit (gdbarch, 64);
set_gdbarch_reg_struct_has_addr (gdbarch,
mips_o32_reg_struct_has_addr);
- set_gdbarch_use_struct_convention (gdbarch,
- mips_o32_use_struct_convention);
+ set_gdbarch_use_struct_convention (gdbarch, always_use_struct_convention);
break;
case MIPS_ABI_EABI32:
set_gdbarch_push_dummy_call (gdbarch, mips_eabi_push_dummy_call);