Re: [branch patch] core files as symfiles

[Daniel Jacobowitz <drow at mvista dot com>]

On Thu, May 15, 2003 at 11:57:51PM +0200, Mark Kettenis wrote:
>    Date: Mon, 12 May 2003 19:58:57 -0700
>    From: Roland McGrath <roland@redhat.com>
> 
>    The following patch causes core files to be implicitly read as symbol files
>    as well.  Using this along with my previous dwarf-frame.c patch vs current
>    kettenis_i386newframe-20030419-branch gdb, on Linux 2.5.69 on x86 the
>    backtrace of a thread in a system call from a core dump Just Works.
> 
>    I've included the trivial symfile.c patch that was in with my dwarf-frame.c
>    patch again here too, since it's required for the corelow.c patch to work
>    and these patches work (but cause nothing interesting to happen)
>    independent of the dwarf-frame.c changes.
> 
> The patch looks fine to me, although I'd like to see the opinion of
> another GDB developer who's more familiar with this part of the code.

I can't claim to be familiar with this code, but the patch also looks
reasonable to me.

> Since this code doesn't depend on any other changes in the
> i386newframe branch, perhaps this should go into mainline, and we can
> simply merge it into the branch from there.  If you think so, please
> resubmit this without the reference to "branch" in the subject.

I think this would be a good idea.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer