Re: [RFA] Remove calls to inside_entry_file

[Daniel Jacobowitz <drow at mvista dot com>]

On Wed, Apr 02, 2003 at 11:27:41AM +0200, Corinna Vinschen wrote:
> On Tue, Apr 01, 2003 at 02:58:32PM -0500, Daniel Jacobowitz wrote:
> > On Tue, Apr 01, 2003 at 12:30:49PM -0500, Andrew Cagney wrote:
> > > >
> > > >Oh, you wrote "Consider that approved" so I didn't thought I'd have
> > > >to send it again to gdb-patches.  However, what about the important
> > > >part of my posting:
> > > 
> > > Yes, just please always post changes.
> > > 
> > > >>I've checked in the frame.c patch but still, I don't understand this
> > > >>decision.  So called out-of-date targets can easily add the
> > > >>inside_entry_file() call to their frame_chain_valid() implementation
> > > >>so removing this call from blockframe.c does not necessarily break
> > > >>them.  Keeping this call in blockframe.c on the other hand breaks
> > > >>some targets for which this call is plainly wrong.  So the logic would
> > > >>imply to remove the call in favour of *all* targets able to run correctly.
> > > 
> > > Per my previous comment, I'd prefer to not touch the old code at all - 
> > > let it die.  Mark, I'll note, already has i386 replacement code in waiting.
> > > 
> > > The other thing to do is to ask DanielJ if he knows anything more about 
> > > that specific case.
> > 
> > Nope.  It was there before I put my hands on it; it seems suspicious to
> > me though.
> 
> What do you mean by "suspicious"?  You did already comment on this in
> blockframe.c so I assume you had rather mixed feelings about this call.

By "suspicious" I mean that I don't see why it would be necessary.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer