This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/RFC] disable-nls if msgfmt could not be found
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 18 Mar 2003 11:51:54 -0500
- Subject: Re: [RFA/RFC] disable-nls if msgfmt could not be found
- References: <20030318034633.GO16507@gnat.com>
On Mon, Mar 17, 2003 at 07:46:34PM -0800, Joel Brobecker wrote:
> Hello,
>
> I hope I am sending this to the right list...
Sort of. Patches to toplevel configure need to also go to gcc-patches@
and binutils@; generally (i.e. in practice) only Alexandre Oliva and DJ
Delorie approve them.
> Some users building GDB on systems where msgfmt is not available were
> blocked when the build failed (in bfd, and probably another subdir
> that I can't remember). See
> http://sources.redhat.com/ml/gdb/2003-02/msg00310.html.
>
> Instead of adding the checks in each subdir, I thought that it might be
> better to do the check for msgfmt in the toplevel configure, and pass
> --disable-nls to the subdir configure commands if not found. The
> following patches tries to do this, and has been tested on a hpux box
> where msgfmt is missing, and on a linux machine where msgfmt was
> available.
>
> Ideally, we want to do the check for msgfmt only if --disable-nls was
> not already specified. However, the only consequence of not checking
> for the presence of --disable-nls is that we might have more than one
> --disable/enable-nls switches on the subdir configure commands. I
> think it will be ok, since I've placed the --disable-nls at the end
> so it should overide the user's switch. An AC_MSG_WARN may also have
> been nice, but I decided against it because seeing a warning even
> when the user has specified --disable-nls would seem strange...
>
> Would the following change be acceptable for inclusion?
>
> 2003-03-17 J. Brobecker <brobecker at gnat dot com>
>
> * configure.in: Add check for msgfmt, configure subdir with
> --disable-nls if not found.
> * configure: Regenerate.
>
> --
> Joel
> Index: configure.in
> ===================================================================
> RCS file: /cvs/src/src/configure.in,v
> retrieving revision 1.158
> diff -c -3 -r1.158 configure.in
> *** configure.in 12 Mar 2003 20:47:07 -0000 1.158
> --- configure.in 18 Mar 2003 03:43:33 -0000
> ***************
> *** 1824,1829 ****
> --- 1824,1838 ----
> *) gxx_include_dir=${with_gxx_include_dir} ;;
> esac
>
> + # Check that msgfmt can be found in the PATH, or configure with
> + # --disable-nls to avoid a build failure.
> + AC_CHECK_PROG(MSGFMT, msgfmt, msgfmt, )
> + if [ test "x$MSGFMT" = "x" ]; then
> + build_configargs="${build_configargs} --disable-nls"
> + host_configargs="${host_configargs} --disable-nls"
> + target_configargs="${target_configargs} --disable-nls"
> + fi
> +
> FLAGS_FOR_TARGET=
> case " $target_configdirs " in
> *" newlib "*)
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer