This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] missing frame_register


On Mon, 2003-03-17 at 11:47, David Carlton wrote:

I was hoping not to have to do anything about this until later (let 'em
sweat for a few hours! :v), but I don't believe the below will work: 

> +    frame_register (deprecated_selected_frame, regnum, &optim,
> +		    NULL, NULL, &realnum, raw_buffer);

In frame.c:

void
frame_register (struct frame_info *frame, int regnum,
                int *optimizedp, enum lval_type *lvalp,
                CORE_ADDR *addrp, int *realnump, void *bufferp)
{
  /* Require all but BUFFERP to be valid.  A NULL BUFFERP indicates
     that the value proper does not need to be fetched.  */
  gdb_assert (optimizedp != NULL);
  gdb_assert (lvalp != NULL);
  gdb_assert (addrp != NULL);
  gdb_assert (realnump != NULL);
  /* gdb_assert (bufferp != NULL); */

I have a patch that does work (I think), and I will check it in
momentarily, unless you want to follow through. I've done exactly the
same as you, expect I called frame_reigster with no NULL values. Six of
one, half-dozen of the other, I think.

I'll check mine in if I don't see a commit from you. I appreciate your
thinking of me, urgh, insight!

Keith





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]