This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Prologue detection on x86-64
- From: Michal Ludvig <mludvig at suse dot cz>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: GDB Patches <gdb-patches at sources dot redhat dot com>
- Date: Fri, 07 Mar 2003 00:14:55 +0100
- Subject: Re: [RFA] Prologue detection on x86-64
- Organization: SuSE CR
- References: <3E67D22C.3030908@suse.cz> <20030306231007.GA9627@nevyn.them.org>
Daniel Jacobowitz wrote:
On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote:
+/* We will handle only functions beginning with:
+ 55 pushq %rbp
+ 48 89 e5 movq %rsp,%rbp */
Period and two spaces, please.
Period after %rbp? It wouldn't be an assembler anymore :-(
How about two spaces and no period instead? (compromise :-)
+#define PROLOG_BUFSIZE 4
+static int
+x86_64_function_has_prologue (CORE_ADDR pc)
+int x86_64_function_has_prologue (CORE_ADDR pc);
That's probably a warning. Static functions don't need to be
prototyped in the tdep.h file; this bit can just be omitted.
Oops, sorry. Shouldn't be static, because it will be used in
x86-64-linux-tdep.c, so I need a prototype in x86-64-tdep.h.
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig at suse dot cz
* (+420) 296.545.373 * http://www.suse.cz