This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Step over Objective-C dispatch function


Just on the coding side (let michael handle the technical bit :-). That file contains the nastiest code known to GDB so all possible effort should be spent on ensuring that the new code is understandable.

   CORE_ADDR tmp;
Hmm, looks like the variable tmp needs a re-name, it's definitly no longer tmp - it's carrying a meaningful value.

+  CORE_ADDR new_stop;
this declaration should be moved as close as possible to its use (and again given a descriptive name).

> + /* Step over Objective-C dispatch function. */

Following on from michael's comment, this needs a detailed description of what is happening here.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]