This is the mail archive of the
mailing list for the GDB project.
Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 03 Jan 2003 17:15:34 -0500
- Subject: Re: RFC/gdbarch: Make OS ABI a real member of the gdbarch
- References: <20021228001850.GA2127@nevyn.them.org>
Yes, much better.
I belive that both of these `= ...' can be dropped - since info.osabi is
explicitly initialized, no magic values are needed. This is also more
consistent with it being a named enum.
+ GDB_OSABI_UNINITIALIZED = -1, /* For struct gdbarch_info. */
+ GDB_OSABI_UNKNOWN = 0, /* keep this zero */
Hmm, why was the enum to a new file? Ah! Ulgh, "gdbarch.h" needs the
definition :-/ Rather than create a new file, just move the enum to
"defs.h". This is consistent with other, similar, enums solved the
problem. It also stops me thinking that "osabi.h" should include
"osabi-list.h" (nb, s/_/-/) :-)