This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Rename remote protocol's CRC function


The documentation for the remote protocol probably ought to specify
which CRC is to be used for the qCRC packet; at the moment, the only
way to find out is to go read remote.c.  The function's comment should
also describe it.  Unfortunately, I don't understand CRC's well enough
to dope this stuff out myself.


As michael noted, it is static. Consequently I think just `remote_crc32' is sufficient.

Can you please expand the comment:

+/* The 32-bit CRC function used for the remote protocol's qCRC
+   packet.  */
to also mention, as you did in the cover note, that this is just one member of a family of CRC funtions.

As for the doco, I'd bug report that.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]