This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/RFA] GDB crash when using command lines due to memory corruption
- From: Joel Brobecker <brobecker at gnat dot com>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: Klee Dienes <klee at apple dot com>, gdb-patches at sources dot redhat dot com
- Date: Thu, 12 Dec 2002 10:42:32 +0100
- Subject: Re: [RFC/RFA] GDB crash when using command lines due to memory corruption
- References: <8096FEF2-0D32-11D7-9BDD-00039396EEB8@apple.com> <3DF7C8AB.6822A575@redhat.com>
> > A safer change for 5.3 might be the patch I submitted on October 30th.
> >
> > http://sources.redhat.com/ml/gdb-patches/2002-10/msg00586.html
> >
>
> Joel, would Klee's change satisfy your requirement?
Absolutely. Klee's change is actually the first solution I came up with,
but for some reason I remembered that there was a reluctance to copy
this command lines structure more often than necessary. To be fair, I
really like Klee's change over mine, as it is much simpler and much more
maintainable. Can Klee's change be approved, and can Klee do the
checkin? I can also do the checkin on Klee's behalf if he's busy.
He's addition testcase is also a useful addition to our testsuite.
One small detail, is about memory management. Did anybody make sure that
there is no memory leak introduced in this change?
Speaking of memory leaks, there is the small change is
bpstat_stop_status which I will resubmit separately.
Thanks,
--
Joel