Re: [RFC/RFA] GDB crash when using command lines due to memory corruption

[Michael Snyder <msnyder at redhat dot com>]

Klee Dienes wrote:
> 
> A safer change for 5.3 might be the patch I submitted on October 30th.
> 
>         http://sources.redhat.com/ml/gdb-patches/2002-10/msg00586.html
> 
> Rather than deal with sharing the command-line structure, I just
> updated bpstat_copy to match its comment, and do a deep copy of the
> command lines as well as the value.  I don't really have a strong
> opinion about copying the command lines vs. managing them the way Joel
> proposes, although my patch does have the argument of simplicity going
> for it.  On the other hand, if/when we go to a more sophistiated
> command-line evaluator, we'll probably want the command body to be some
> opaque and externally managed structure anyway.
> 
> Whichever patch we end up taking, though, we should be sure to update
> the comment in bpstat_copy and add my proposed change to the test suite.

Joel, would Klee's change satisfy your requirement?