This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] dwarf2read.c: complain() -> complaint()
- From: ac131313 at redhat dot com (Andrew Cagney)
- To: Jim Blandy <jimb at redhat dot com>
- Cc: Andrew Cagney <ac131313 at redhat dot com>,gdb-patches at sources dot redhat dot com
- Date: Wed, 11 Dec 2002 15:07:06 -0500 (EST)
- Subject: Re: [RFA] dwarf2read.c: complain() -> complaint()
> It looks fine to me.
>
> I was uncomfortable with the idea of having to create wrapper
> functions at first --- the idea being that each occurrence of a
> complaint string is its own independent complaint --- but it seems
> like it'll do the right thing by default more often than making people
> create complaint structures. So I'll go with that.
I'm not sure what you mean. The wrapper function was only suggested
when an identical complaint is being reported from more than one place
in the file. See "complaints.h".
Andrew