This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/RFA] GDB crash when using command lines due to memory corruption
- From: Klee Dienes <klee at apple dot com>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 11 Dec 2002 13:00:58 -0500
- Subject: Re: [RFC/RFA] GDB crash when using command lines due to memory corruption
A safer change for 5.3 might be the patch I submitted on October 30th.
http://sources.redhat.com/ml/gdb-patches/2002-10/msg00586.html
Rather than deal with sharing the command-line structure, I just
updated bpstat_copy to match its comment, and do a deep copy of the
command lines as well as the value. I don't really have a strong
opinion about copying the command lines vs. managing them the way Joel
proposes, although my patch does have the argument of simplicity going
for it. On the other hand, if/when we go to a more sophistiated
command-line evaluator, we'll probably want the command body to be some
opaque and externally managed structure anyway.
Whichever patch we end up taking, though, we should be sure to update
the comment in bpstat_copy and add my proposed change to the test suite.