This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] New method find_frame_sal()


On Thu, 28 Nov 2002, Andrew Cagney wrote:


While cleaning up accesses to the `struct frame_info', I kept coming across code snippits like:

sal = find_pc_line (fi->pc,
(fi->next != (struct frame_info *) NULL
&& !(get_frame_type (fi->next) == SIGTRAMP_FRAME)
&& !(get_frame_type (fi->next) == DUMMY_FRAME)));

(Originally it was worse, as there was also fi->signal_handler_caller and PC_IN_CALL_DUMMY (fi->pc, fi->frame, fi->frame).)

The attached patch adds the function:

find_frame_sal(fi, &sal);

that encapsulates all of the above.

Should this method be documented in gdbint.texinfo perhaps?
Um, to this level of detail, I don't think so.

The thing I think is missing is a `Frames' chapter which describes how things hang together. Guess why I've not got back to you with that frames doco patch I posted ....

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]