Re: [PATCH] Redefine skip_quoted

[Elena Zannoni <ezannoni at redhat dot com>]

Adam Fedor writes:
 > Elena Zannoni wrote:
 > > Adam Fedor writes:
 > >  > Elena Zannoni wrote:
 > >  > > Adam Fedor writes:
 > >  > >  > Jim Blandy wrote:
 > >  > >  > > Klee Dienes <klee@apple.com> writes:
 > >  > >  > > 
 > >  > >  > >>In the Apple code, we use skip_quoted to allow for the possibility of
 > >  > >  > >>spaces in Objective-C function names.
 > >  > >  > >>
 > >  > >  > >>I'm actually coming to think that allowing people to break on unquoted
 > >  > >  > >>Objective-C methods was a mistake: it's caused us no end of trouble
 > >  > >  > >>trying to shoehorn decode_line_1() into handling every possible
 > >  > >  > >>edge-case.  I'm not sure how practical it is for us to remove it at
 > >  > >  > >>this point, though --- we'd have to do some research among our
 > >  > >  > >>Objective-C developers to find out how important a feature it is to
 > >  > >  > >>them, I think.
 > >  > >  > > 
 > >  > >  > > 
 > >  > >  > > So, the original patch posted is preparation for a behavior which you
 > >  > >  > > now suspect was a mistake, and which has caused you no end of trouble?
 > >  > >  > > (Or do I have the sense of what you were saying reversed?)  You can
 > >  > >  > > forgive me if hearing that makes me a bit hesitant to approve the
 > >  > >  > > patch, right?  :)
 > >  > >  > > 
 > >  > >  > 
 > >  > >  > Well, really the use of skip_quoted for ObjC (in a patch that I haven't 
 > >  > >  > submitted yet), really has more to do with handling the canonical form 
 > >  > >  > of an Objective-C method symbol (e.g. -[MyObject myMethod:arg2:]) that 
 > >  > >  > comes from objc-lang.c. Most of the breakpoint cases that a user would 
 > >  > >  > enter are handled elsewhere (in a patch that I also haven't submitted).
 > >  > >  > 
 > >  > > 
 > >  > > I have to agree with Jim here, I think we should wait on the parts you
 > >  > > haven't submitted before deciding on this one. Could you just have
 > >  > > added the chars you need to the gdb_completer_word_break_characters
 > >  > > variable?
 > >  > > 
 > >  > 
 > >  > No. It involves removing characters. Another option would be to define a 
 > >  > new function, say skip_objc_quoted, just for objc which would be similar 
 > >  > to skip_quoted. How about that?
 > > 
 > > Hmmm,...
 > > I think the best approach would be to continue what you started, then,
 > > and define another set (sonething like
 > > gdb_objc_completer_word_break_characters), and have the
 > > get_... function return the correct one based on the current
 > > language. Is that what you were going to do?
 > > 
 > 
 > That wasn't my intention, but I could look at that. However, I don't 
 > know if there is a global variable that holds the current language, is 
 > there? If it involved adding another paramter to skip_quoted, then that 
 > goes back to the original complaint that it involves changing the usage 
 > of skip_quoted in a bunch of places (I think?).
 > 

current_language->la_language, maybe? but it could be set to language_auto,
so it doesn't seem too useful...

 > I'm sure it would nice for everyone to see how this works (in fact you 
 > can, by looking at the (now outdated) original patch at 
 > ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz). But 
 > submitting an  everything-becomes-clear patch goes against Andrew's 
 > original suggestion of breaking the patch up into pieces.
 > 

I think that it would actually be beneficial to post a list of patches
that are still pending. I am getting a bit confused about the status
of objective C, given that everything was under the same mail subject.
That would help.

Thanks
Elena


 > 
 > 
 > -- 
 > Adam Fedor, Digital Optics Corp.      | I'm glad I hate spinach, because
 > http://www.doc.com                    | if I didn't, I'd eat it, and you
 >                                        | know how I hate the stuff.