This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Delete struct source, struct sourcevector from symtab.h
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: David Carlton <carlton at math dot stanford dot edu>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 18 Oct 2002 19:38:58 -0400
- Subject: Re: [RFA] Delete struct source, struct sourcevector from symtab.h
- References: <ro1fzv38hko.fsf@jackfruit.Stanford.EDU>
David Carlton writes:
> symtab.h contains definitions for 'struct source' and 'struct
> sourcevector', but nobody ever refers to them. If you look through
> ChangeLog-1999, you see the comment:
>
> * symtab.h: Remove struct sourcevector and struct source. Definately
> not needed.
>
> But, despite that, they haven't actually been removed. Oops.
>
Are those the only references? Wow.
> Here's a patch; I've compiled and checked, and they really aren't
> referred to anywhere. OK?
>
Cool, yes, thanks.
Elena
> David Carlton
> carlton@math.stanford.edu
>
> 2002-10-18 David Carlton <carlton@math.stanford.edu>
>
> * symtab.h: Delete 'struct source' and 'struct sourcevector'.
>
> Index: symtab.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.h,v
> retrieving revision 1.43
> diff -u -p -r1.43 symtab.h
> --- symtab.h 15 Oct 2002 02:50:56 -0000 1.43
> +++ symtab.h 18 Oct 2002 22:11:11 -0000
> @@ -750,15 +750,6 @@ struct partial_symbol
> #define PSYMBOL_CLASS(psymbol) (psymbol)->aclass
>
>
> -/* Source-file information. This describes the relation between source files,
> - line numbers and addresses in the program text. */
> -
> -struct sourcevector
> -{
> - int length; /* Number of source files described */
> - struct source *source[1]; /* Descriptions of the files */
> -};
> -
> /* Each item represents a line-->pc (or the reverse) mapping. This is
> somewhat more wasteful of space than one might wish, but since only
> the files which are actually debugged are read in to core, we don't
> @@ -795,14 +786,6 @@ struct linetable
> `struct hack', you can shove it up your ANSI (seriously, if the
> committee tells us how to do it, we can probably go along). */
> struct linetable_entry item[1];
> -};
> -
> -/* All the information on one source file. */
> -
> -struct source
> -{
> - char *name; /* Name of file */
> - struct linetable contents;
> };
>
> /* How to relocate the symbols from each section in a symbol file.