I don't understand the purpose of this patch.
Instead of havingb skip_quoted use gdb_completer_word_break_characters
directly, it adds an argument to skip_quoted, and then passes the
return value from get_gdb_completer_word_break_characters () in every
case. But the Objective-C case does exactly the same thing as all the
other cases; it doesn't behave any differently.
Is this some sort of preparatory patch for something else? What's
coming down the line?
Michael Snyder <msnyder@redhat.com> writes:
Adam Fedor wrote:
Objective-C has a different idea of what word break characters are.
Hence this patch (although the new usage isn't actually apparent in
this
patch).
I think you need Jim or Elena's buy-in for the change in linespec.c,
but I'll approve the rest. Jim, Elena's on vacation -- can you give
a quick look at this?
2002-10-04 Adam Fedor <fedor@gnu.org>
* Makefile.in (c-exp.tab.o): Add $(completer_h) to
dependancies.
(jv-exp.tarb.o): Likewise.
(p-exp.tab.o): Likewise.
* completer.c (skip_quoted): Take additional "word break
characters" argument.
* completer.h: Update definition of skip_quoted.
* defs.h (skip_quoted): Delete, declared in completer.h.
* c-exp.y: Include completer.h. Update definition of
skip_quoted.
* p-exp.y: Likewise.
* jv-exp.y: Likewise.
* linespec.c (decode_line_1): Likewise.