This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I have been following the TUI developments on the gdb-5.3 branch. My interest is in using TUI for a cross debugger (m68k-palmos, see http://prc-tools.sourceforge.net). I found some problems with the current state of the TUI. This post is concerned with secondary prompts. When tui is active, secondary prompts do not work. Try to do a command with many lines of output, i.e. 'show copying'. You will not get the '---Type <return> to continue, or q <return> to quit---' prompt, but just the normal (gdb) prompt. Same is true when prompting for commands in the 'commands' command for commands to be executed at a breakpoint. Tui relies on the prompt stack. However this stack is not used for these cases. I 'fixed' it by adding a push_prompt/pop_prompt pair around the readline() call in gdb_readline_wrapper. Also had to fix the pop_prompt logic for the changing annotation level case as a consequence. I do not know if this has repercussions in other areas of gdb, so I happily accept criticisms or proposals to fix this in a better way. Here is the Changelog entry for my fix (and patch attached). Diff is against the branch snapshot from today (2002-10-01). 2002-10-01 Ton van Overbeek (v-overbeek@cistron.nl) * event-top.h: Introduced change_annotation_level parameter to pop_prompt (). * event-top.c (pop_prompt): Added change_annotation_level parameter. (change_annotation_level, async_enable_stdin, command_line_handler): Use new parameter in pop_prompt. * top.c (gdb_readline_wrapper): Added push-prompt/pop_prompt pair around readline call for tui secondary prompts to work. I hope this patch is accepted. If I need to complete a copyright assignment for this, let me know. Ton van Overbeek
Attachment:
tui-sec-prompts.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |