This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] New bitflags type and eflags on i386/x86-64
Daniel Jacobowitz wrote:
Well, actually, I like it.
Wow! That's a surprise! :-)))
Some textual changes and comments:
Thanks, I'm not a native speaker ;-)
+ builtin_type_i386_eflags =
+ init_flags_type (32 /* EFLAGS_LENGTH */,
+ "__i386_eflags", (struct objfile *) NULL);
+ add_flag_name (builtin_type_i386_eflags, 0, "CF");
>>+ builtin_type_simd_mxcsr =
>>+ init_flags_type (32 /* EFLAGS_LENGTH */,
>>+ "__simd_mxcsr", (struct objfile *) NULL);
>>+ add_flag_name (builtin_type_simd_mxcsr, 0, "IE");
> Do these really need to be in common code? That's gross. Yes, I know
> a whole lot of others are, but those are all floatformats or standard
> vectors.
> This should be in i386-tdep.c.
I don't compile i386-tdep.c for x86-64. Should I duplicate the code for
x86-64 or better leave it here to have it only once?
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz