This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Minor reformatting in infrun.c


Joel Brobecker wrote:
> 
> > Err, I was actually meaning to say "let's conform with indent",
> > rather than "let's defeat indent".  How about moving the comment
> > outside the argument list?  Then the args can stay as they were.
> 
> I see what you mean now. I should have tried it before, instead of
> assuming that moving the comment up would not prevent indent from
> formatting the args back to the same previous unreadable way (I did not
> realize that the comment had this effect in the formatting result)...
> 
> I can commit the following patch. I verified that a later re-indent
> does not cause a formatting change in the second argument.

Yes, and now I can see no reason not to put the arguments back
the way they were originally.  Or, say. 

  stop_bpstat =
    bpstat_stop_status (&stop_pc, 
                        [...]

I think it's more natural and readable than moving the paren down.

> 2002-08-23  Joel Brobecker  <brobecker@gnat.com>
> 
>         * infrun.c (handle_inferior_event): Move a comment outside of a
>         function call, in order to avoid indent reformatting this part
>         of the code in an unreadable way.
> 
> --
> Joel
> 
>   ------------------------------------------------------------------------
> 
>    infrun.c.diffName: infrun.c.diff
>                 Type: Plain Text (text/plain)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]