This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH] delete DEFAULT_MIPS_TYPE
- From: Michael Snyder <msnyder at redhat dot com>
- To: gdb-patches at sources dot redhat dot com, cagney at redhat dot com
- Date: Wed, 21 Aug 2002 15:23:47 -0700
- Subject: [PATCH] delete DEFAULT_MIPS_TYPE
- Organization: Red Hat, Inc.
Speaking of macros being evil, here's one that isn't used any more...
2002-08-21 Michael Snyder <msnyder@redhat.com>
* mips-tdep.c (DEFAULT_MIPS_TYPE): Delete unused macro.
* config/mips/tm-mips.h (DEFAULT_MIPS_TYPE): Delete unused macro.
* config/mips/tm-embed.h (DEFAULT_MIPS_TYPE): Delete unused macro.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.117
diff -p -r1.117 mips-tdep.c
*** mips-tdep.c 21 Aug 2002 22:18:25 -0000 1.117
--- mips-tdep.c 21 Aug 2002 22:32:07 -0000
*************** mips_gdbarch_init (struct gdbarch_info i
*** 5914,5919 ****
--- 5914,5922 ----
register name management is part way between the old -
#undef/#define REGISTER_NAMES and the new REGISTER_NAME(nr).
Further work on it is required. */
+ /* NOTE: many targets (esp. embedded) do not go thru the
+ gdbarch_register_name vector at all, instead bypassing it
+ by defining REGISTER_NAMES. */
set_gdbarch_register_name (gdbarch, mips_register_name);
set_gdbarch_read_pc (gdbarch, mips_read_pc);
set_gdbarch_write_pc (gdbarch, generic_target_write_pc);
*************** mips_dump_tdep (struct gdbarch *current_
*** 6131,6139 ****
fprintf_unfiltered (file,
"mips_dump_tdep: CPLUS_MARKER = %c\n",
CPLUS_MARKER);
- fprintf_unfiltered (file,
- "mips_dump_tdep: DEFAULT_MIPS_TYPE = %s\n",
- DEFAULT_MIPS_TYPE);
fprintf_unfiltered (file,
"mips_dump_tdep: DO_REGISTERS_INFO # %s\n",
XSTRING (DO_REGISTERS_INFO));
--- 6134,6139 ----
Index: config/mips/tm-mips.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-mips.h,v
retrieving revision 1.42
diff -p -r1.42 tm-mips.h
*** config/mips/tm-mips.h 21 Aug 2002 01:08:23 -0000 1.42
--- config/mips/tm-mips.h 21 Aug 2002 22:32:07 -0000
*************** struct value;
*** 46,56 ****
#define GDB_TARGET_UNMASK_DISAS_PC(addr) MAKE_MIPS16_ADDR(addr)
#endif
- /* The name of the usual type of MIPS processor that is in the target
- system. */
-
- #define DEFAULT_MIPS_TYPE "generic"
-
/* Return non-zero if PC points to an instruction which will cause a step
to execute both the instruction at PC and an instruction at PC+4. */
extern int mips_step_skips_delay (CORE_ADDR);
--- 46,51 ----
Index: config/mips/tm-embed.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-embed.h,v
retrieving revision 1.4
diff -p -r1.4 tm-embed.h
*** config/mips/tm-embed.h 6 Mar 2001 08:21:32 -0000 1.4
--- config/mips/tm-embed.h 21 Aug 2002 22:32:07 -0000
***************
*** 19,27 ****
#include "mips/tm-bigmips.h"
- #undef DEFAULT_MIPS_TYPE
- #define DEFAULT_MIPS_TYPE "r3051"
-
/* Watchpoint support */
#define TARGET_HAS_HARDWARE_WATCHPOINTS
--- 19,24 ----