This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] mips-tdep.c: local defines, static functions
- From: Andrew Cagney <ac131313 at ges dot redhat dot com>
- To: Michael Snyder <msnyder at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com, cagney at redhat dot com
- Date: Tue, 20 Aug 2002 21:29:29 -0400
- Subject: Re: [PATCH] mips-tdep.c: local defines, static functions
- References: <200208210038.g7L0ci300745@reddwarf.sfbay.redhat.com>
+ #define MSYMBOL_IS_SPECIAL(msym) \
+ (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0)
+ #define MSYMBOL_SIZE(msym) \
+ ((long) MSYMBOL_INFO (msym) & 0x7fffffff)
+
``Macro's are bad m'kay.''
Could you please retain these functions:
- /* MSYMBOL_IS_SPECIAL tests the "special" bit in a minimal symbol. */
-
- int
- mips_msymbol_is_special (struct minimal_symbol *msym)
- {
- return (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0);
- }
-
- /* MSYMBOL_SIZE returns the size of the minimal symbol, i.e. the
- "info" field with the "special" bit masked out. */
-
- long
- mips_msymbol_size (struct minimal_symbol *msym)
- {
- return ((long) MSYMBOL_INFO (msym) & 0x7fffffff);
- }
-
and instead replace references to MSYMBOL_IS_SPECIAL() with simple
function calls.
Andrew