This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/ob] not_a_breakpoint -> not_a_sw_breakpoint


On Fri, Aug 16, 2002 at 11:37:34AM -0400, Andrew Cagney wrote:
> Hello,
> 
> This patch renames the ``not_a_breakpoint'' parameter of 
> bpstat_stop_status() to the more correct ``not_a_sw_breakpoint'' so that 
> it is clear that it is indicating nothing about hardware breakpoints.
> 
> committed,
> Andrew

Great.  I'm going to have to think about this a little more though; if
you look in infrun.c you'll see that this parameter sometimes comes
from catchpoints, which is unfortunate since we have nowhere that
indicates whether a catchpoint is affected by DECR_PC_AFTER_BREAK or
not.

(For i386/Linux, when I'm done with it, I believe that throw and catch
catchpoints WILL be affected by decr_pc_after_break.... and that
fork/exec/vfork catchpoints WON'T be.  I had to hack around this in my
work tree.)

Do I remember someone commenting that DECR_PC_AFTER_BREAK was a mess,
perhaps?  I think I do... :)

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]