This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Call FRAME_INIT_SAVED_REGS instead of mips_find_saved_regs



In the course of multiarching FRAME_INIT_SAVED_REGS, I did consider
adding the necessary bits of code for setting
frame->saved_regs[SP_REGNUM] in mips_find_saved_regs, but decided it
would be more obvious if I did a straightforward translation of the
(now replaced) macro.  The elimination of mips_find_saved_regs() can
wait for another day.  After this patch though, there'll only be one
caller, so it'll be easier to merge mips_find_saved_regs into
mips_frame_init_saved_regs().
Can you please add a comment to mips_find_saved_regs() indicating this.

Otherwize approved.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]