This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] revised mips use_struct_convention
- From: Andrew Cagney <ac131313 at ges dot redhat dot com>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 07 Aug 2002 15:40:44 -0400
- Subject: Re: [RFA] revised mips use_struct_convention
- References: <3D504E01.F3D087A9@redhat.com>
Redone using gdbarch method.
> 2002-08-06 Michael Snyder <msnyder@redhat.com>
>
> * config/mips/tm-mips.h: Remove #define USE_STRUCT_CONVENTION.
> * mips-tdep.c (mips_EABI_use_struct_convention,
> mips_OABI_use_struct_convention, mips_NABI_use_struct_convention):
> New functions. (mips_use_struct_convention): Delete.
> (mips_gdbarch_init): set use_gdbarch_convention.
Just a few tweaks:
Per other patch, can you change EABI->eabi, NABI->n32n64, OABI->o32.
Also be sure to check that it builds and works ok. The below won't compile:
extern CORE_ADDR mips_push_arguments (int, struct value **, CORE_ADDR, int,
! CORE_ADDR);
#define PUSH_ARGUMENTS(nargs, args, sp, struct_return, struct_addr) \
! (mips_push_arguments((nargs), (args), (sp), (struct_return), (struct_addr)))
extern CORE_ADDR mips_push_return_address (CORE_ADDR pc, CORE_ADDR sp);
#define PUSH_RETURN_ADDRESS(PC, SP) (mips_push_return_address ((PC), (SP)))
--- 326,334 ----
handle it. */
extern CORE_ADDR mips_push_arguments (int, struct value **, CORE_ADDR, int,
! CORE_ADDR, int);
#define PUSH_ARGUMENTS(nargs, args, sp, struct_return, struct_addr) \
! (mips_push_arguments((nargs), (args), (sp), (struct_return), (struct_addr), using_gcc))
extern CORE_ADDR mips_push_return_address (CORE_ADDR pc, CORE_ADDR sp);
#define PUSH_RETURN_ADDRESS(PC, SP) (mips_push_return_address ((PC), (SP)))
Andrew