This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[RFA] 32/64 mistake in mips_find_saved_regs
- From: Michael Snyder <msnyder at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: cagney at redhat dot com, kevinb at redhat dot com
- Date: Mon, 05 Aug 2002 21:47:38 -0700
- Subject: [RFA] 32/64 mistake in mips_find_saved_regs
- Organization: Red Hat, Inc.
Here is a test that should check for stack/register size, not
whether target == mips64.
Fixes four failures in callfuncs.exp, no other regressions.
2002-08-05 Michael Snyder <msnyder@redhat.com>
* mips-tdep.c (mips_find_saved_regs): Adjust stack according
to MIPS_SAVED_REGSIZE, not GDB_TARGET_IS_MIPS64. N32 is not
MIPS64, but it does save 64 bits worth of register.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.88
diff -p -r1.88 mips-tdep.c
*** mips-tdep.c 1 Aug 2002 23:10:34 -0000 1.88
--- mips-tdep.c 6 Aug 2002 04:32:33 -0000
*************** mips_find_saved_regs (struct frame_info
*** 1371,1379 ****
were saved. */
reg_position = fci->frame + PROC_FREG_OFFSET (proc_desc);
! /* The freg_offset points to where the first *double* register
! is saved. So skip to the high-order word. */
! if (!GDB_TARGET_IS_MIPS64)
reg_position += MIPS_SAVED_REGSIZE;
/* Fill in the offsets for the float registers which float_mask says
--- 1371,1379 ----
were saved. */
reg_position = fci->frame + PROC_FREG_OFFSET (proc_desc);
! /* The freg_offset points to where the first *double* register is
! saved. So skip to the high-order word if saved_reg_size == 4. */
! if (MIPS_SAVED_REGSIZE == 4)
reg_position += MIPS_SAVED_REGSIZE;
/* Fill in the offsets for the float registers which float_mask says