This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] unneeded extra brace in infrun.c (handle_inferior_event)


Joel Brobecker writes:
 > While reading the code, I found this comment along the extra unneeded
 > brace:
 > 
 >      /* Keep this extra brace for now, minimizes diffs.  */
 >      {
 > 
 > This brace causes an extra 2 characters indentation to the right for the
 > entire function (which is quite long, actually).  No big deal, but it
 > would take me very little time to remove it if that's useful. Shall I do
 > it?
 > 
 > -- 
 > Joel

I remember that! (Does that mean I am becoming an old timer? Oh dear.)
The comment was introduced by Stan when he did some major cleanup of
this function (at the time called wait_for_inferior).  There were so
many changes that adding formatting changes would have made really
difficult to track (and back possibly back out) all the functional
ones.

I vote for reindenting the code. Infrun.c has been on the quiet side
for a bit, and I don't think this change will cause any problems.

Elena


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]