This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Unreviewed patches
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Joern Rennecke <joern dot rennecke at superh dot com>
- Cc: gdb-patches at sources dot redhat dot com, Elena Zannoni <ezannoni at redhat dot com>
- Date: Mon, 1 Jul 2002 11:46:45 -0400
- Subject: Re: Unreviewed patches
- References: <3D205F19.1B99290F@superh.com>
Joern Rennecke writes:
> Wed Jun 12 13:20:51 2002 J"orn Rennecke <joern.rennecke@superh.com>
>
> include/gdb:
> * sim-sh.h: Add enum constants for sh[1-4], sh3e, sh3?-dsp.
Yes, sorry for the delay.
Is there any real reason to not just have one enum, which included the
dsp registers as well? I mean, if the simulator didn't reuse register
numbers for FP regs and DPS regs, then you could get rid of this ugly
code in interp.c:
else case 44:
if (target_dsp)
RE = val;
else case 45: case 46: case 47: case 48: case 49: case 50:
[...]
case 26:
val = target_dsp ? A0 : FI (1);
break;
[...]
etc. etc.
And with that you could get rid of the target_dsp variable.
> sim/sh:
> * Makefile (interp.o): Depend on $(srcroot)/include/gdb/sim-sh.h.
> * interp.c: Include "gdb/sim-sh.h".
> (sim_store_register, sim_fetch_register): Use constants defined there.
>
> http://sources.redhat.com/ml/gdb-patches/2002-06/msg00185.html
>
> Thu Jun 13 23:20:33 2002 J"orn Rennecke <joern.rennecke@superh.com>
>
I think the changes below depend on the cgen patches being accepted first.
Elena
>
> sim/sh64:
> * arch.c, arch.h, cpu.c, cpu.h, cpuall.h, decode-compact.c: Regenerate.
> * decode-compact.h, decode-media.c, decode-media.h: Likewise.
> * defs-compact.h, defs-media.h, sem-compact-switch.c: Likewise.
> * sem-compact.c, sem-media-switch.c, sem-media.c, sh-desc.c: Likewise.
> * sh-desc.h, sh-opc.h: Likewise.
>
> http://sources.redhat.com/ml/gdb-patches/2002-06/msg00490.html
>
> --
> --------------------------
> SuperH
> 2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ
> T:+44 1454 462330