This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Include param.h on FreeBSD/i386
On Sun, Jun 30, 2002 at 12:00:03PM -0700, David O'Brien wrote:
> On Sun, Jun 30, 2002 at 04:54:48PM +0200, Mark Kettenis wrote:
> > "David O'Brien" <obrien@FreeBSD.org> writes:
> >
> > > I applied this patch to both mainline and 5.2_branch:
> > >
> > > 2002-06-28 David O'Brien <obrien@FreeBSD.org>
> > >
> > > * config/i386/nm-fbsd.h: Include <sys/param.h>.
> > > * config/i386/tm-fbsd.h: Likewise.
> >
> > Hi David. Can you tell me why this is needed?
>
> Some code I added to GDB 5.2 in the FreeBSD source tree needs it. That
> code isn't ready to submit back yet. Since the include is benign but I
> wanted to reduce the diffs where easy. I actually don't need it in
> nm-fbsd.h any more.
>
> > Including
> > <sys/param.h> from config/i386/tm-fbsd.h isn't right since this file
> > is going to be removed in the not so distant future,
>
> No problem, I'll reimpliment when that happens.
Including system headers from the tm file is always pretty dodgy - what
do you need it for? How does that include affect cross-debuggers?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer