This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: add_setshow_cmd_full
- From: Tom Tromey <tromey at redhat dot com>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 25 Jun 2002 23:25:46 -0600
- Subject: Re: RFA: add_setshow_cmd_full
- References: <878z53dqr9.fsf@fleche.redhat.com> <3D192849.3080904@cygnus.com>
- Reply-to: tromey at redhat dot com
>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
Andrew> Please be careful to configure GDB with
Andrew> --enable-gdb-build-warnings=,-Werror so that it is compiled
Andrew> with the -Werror flag.
Thanks for catching this. I'm rebuilding with that right now; I wired
it into my standard build script so I won't make this mistake again.
Andrew> Don't forget to remove they stray declaration:
>> +extern struct cmd_list_element *add_setshow_cmd (char *name,
>> + enum command_class class,
>> + var_types var_type, void *var,
>> + char *set_doc, char *show_doc,
Andrew> from the change.
That declaration is part of the change, since I wanted to make
add_setshow_cmd public, and add add_setshow_cmd_full as well. The
latter is only used in a few places.
Would you prefer I use add_setshow_cmd_full everywhere, and just have
90% of the calls have `NULL, NULL' at the end? I can do that...
Tom