This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,...in remote*.c


> This is one of the files that I listed in
> http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
> as still having direct uses of stderr.
> 
>   I don't even know if this is correct,
> because I don't know if the gdb_std???
> should be used in these files.

It should be used everywhere, so yes it is fine.

> remote-array.c seems to also use gdb_stdout
> so that one should be correct.

Yes.

(Eventually GDB needs to audit all its error/output messages and decide 
which should go where.  That, however, is a separate problem.  Probably 
something to do if/when i18n occures.)

> remote-es.c has no other reference to gdb_std???
> variables, so here it could well be an error to do that change.
> 
> Idem for remote-os9k.c and remote-st.c.

These can also also be changed.  gdb_stderr is defined in defs.h, so it 
is visible.

good one,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]