This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Kill SKIP_PROLOGUE_FRAMELESS_P
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: "David S. Miller" <davem at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 21 Apr 2002 14:40:13 -0400
- Subject: Re: [RFA] Kill SKIP_PROLOGUE_FRAMELESS_P
- References: <20020421.020750.82982361.davem@redhat.com>
> This is being done so that we don't have to multi-arch it.
> It's existence is questionable at best.
Good catch.
I don't think anyone expects SKIP_PROLOGUE_FRAMELESS_P to be
multi-arched. Instead, as the tm.h files (or entire architectures -
arc) get deleted, all uses will disappear. That letting the macro slip
quietly off the table.
Giving the occasional macro a good swift shove never hurts.
> Basically, it allowed a target to optimize SKIP_PROLOGUE()
> if we just cared about whether the function was frameless or
> not (ie. lacked any prologue at all).
>
> PROLOGUE_FRAMELESS_P and it's gdbarch equivalent exist and allow
> the target to perform this optimization equivalently.
>
> So we kill SKIP_PROLOGUE_FRAMELESS_P, and for every target that
> provided it we instead make them implement PROLOGUE_FRAMELESS_P.
>
> Now we have one less thing to make multi-arch'able.
As the patch stands, it is dependant on other changes. Can you please
revise this patch so that it is against the existing source base. That
would create an arc_... and sparc_... function, but leave the
sparc_linux_.. function for later.
enjoy,
Andrew