This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MIPS simulator initializes LSI pmon vector table with code


At 19 Apr 2002 11:34:58 -0700, Eric Christopher wrote:
> This was support that worked a while back and the change that Alex is
> reverting broke the LSI support. We aren't supporting something new,
> we're fixing something that someone else broke :)

well, at some point in time perhaps.

it looks like this code has been in the public cvs tree in some form
forever.

rev 1.1 did code like this, but it was moved in rev 1.2 (by fche) to
later in the function and made conditional on perhaps the wrong
variables.


"change that Alex is reverting" isn't a good description: if he
actually had reverted the change that put those there, he would have
put those calls back in their original locations and let the
subsequent vector-setting code do its work afterward, rather than just
commenting them out.


I'm still not seeing anything that convinces me that this change is
correct, or even more correct (using the metric of "number of
platforms broken") than what was there before.


cgd


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]